Opened 8 years ago

Closed 8 years ago

#9066 closed patch (fixed)

Adding and saving animated smileys

Reported by: frasten Owned by: sadrul
Milestone: 2.6.0 Component: pidgin (gtk)
Version: Keywords: animated, smileys, pidgin, add
Cc: datallah

Description (last modified by frasten)

I've written a patch against the mtn trunk, to allow adding animated custom smileys.

It uses the new structs in [b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3] and reads the new animated smiley cache when the smiley is added, instead of using GdkPixBuf. Please review.

Attachments (3)

add-animated-smileys-v0.5.patch (5.6 KB) - added by frasten 8 years ago.
add-animated-smileys-v0.6.patch (10.9 KB) - added by frasten 8 years ago.
add-animated-smileys-v0.7.patch (4.2 KB) - added by frasten 8 years ago.
New version of the patch, allowing to add an animated smiley to your local custom smileys.

Download all attachments as: .zip

Change History (17)

Changed 8 years ago by frasten

comment:1 Changed 8 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

I am not considering this a blocker for 2.6.0.

comment:2 Changed 8 years ago by datallah

  • Description modified (diff)

Changed 8 years ago by frasten

comment:3 Changed 8 years ago by frasten

  • Description modified (diff)

Now the patch allows saving the custom animated smiley to a file.

comment:4 Changed 8 years ago by frasten

  • Summary changed from Adding animated smileys to Adding and saving animated smileys

comment:5 Changed 8 years ago by sadrul@…

  • Milestone changed from Patches Needing Review to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3):
Save raw-data for an image when possible.

This makes it possible to save received animated custom smileys, which was not possible before since GTK+ can't save animated GIFs.

Invalidates and Closes #9066.

comment:6 Changed 8 years ago by frasten

With b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3 you can save animated smileys to a file, but you can't add them directly (still added as png). My patch allowed this, so please reopen this ticket or make this behavior possible.

Changed 8 years ago by frasten

New version of the patch, allowing to add an animated smiley to your local custom smileys.

comment:7 Changed 8 years ago by frasten

I've added another patch against the current mnt trunk, it allows you to add an animated smiley. It completes b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3 and should close this ticket. Please review.

comment:8 Changed 8 years ago by darkrain42

  • Resolution fixed deleted
  • Status changed from closed to new

comment:9 Changed 8 years ago by darkrain42

  • Milestone changed from 2.6.0 to Patches Needing Review

comment:10 Changed 8 years ago by frasten

  • Description modified (diff)

comment:11 Changed 8 years ago by sadrul

  • Owner set to sadrul

comment:12 Changed 8 years ago by sadrul

  • Status changed from new to pending

v0.7 patch looks good.

frasten: What name should we use for you in our COPYRIGHT, ChangeLog, commit message etc?

comment:13 Changed 8 years ago by frasten

  • Status changed from pending to new

My name is Andrea Piccinelli. Thank you!

comment:14 Changed 8 years ago by Andrea Piccinelli <frasten@…>

  • Milestone changed from Patches Needing Review to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 75a466dd96590961d154c6e5d131d85bcae642c6):
Allow adding received animated custom smileys to locale custom smiley collection. Closes #9066.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!