Opened 12 years ago

Last modified 12 years ago

#954 new enhancement

Protocol avatar limitations shouldn't apply to locally set icons for other users

Reported by: contyk Owned by: seanegan
Milestone: Component: pidgin (gtk)
Version: 2.0 Keywords: pidgin avatar buddy icon
Cc:

Description

The image dimensions and file length shouldn't matter for avatars I set for users in my buddy list since it's my local settings. Pidgin complains the file is too long when I drag a custom avatar onto a contact sometimes or it resizes the image dimensions to the contact's protocol limit. This shouldn't occur.

Attachments (1)

avatars-defect-example.png (50.5 KB) - added by contyk 12 years ago.
A picture stands for a thousand of words.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by chckens

I'd agree, enforcing the protocol's restrictions is unnecessary in this case... though allowing large images as avatars has good potential to make a conversation window (with buddy icon shown) unusable.

Might be worth picking sensible maximum dimensions for avatars, and scaling custom avatars to this size rather than based on what the protocol could allow. Anything else would require work to only display thumbnails of the image where space matters (which to my mind is currently only everywhere that avatars are displayed...)

Also, if the problem with file length errors popping up were fixed (see #460) I'd imagine this problem would be much less annoying.

comment:2 follow-up: Changed 12 years ago by lschiere

  • Owner set to seanegan
  • Type changed from defect to enhancement

We have an interest in having some restriction, simply to keep the window usable. I'm tempted to close this "wontfix".

comment:3 in reply to: ↑ 2 Changed 12 years ago by contyk

Replying to lschiere:

We have an interest in having some restriction, simply to keep the window usable. I'm tempted to close this "wontfix".

Sure, but:

  • 1) Why do these depend on the contact's protocol? Isn't it against the current Pidgin philosohpy like it's not about protocols/services, it's about contacts? The dimensions/file length limits should be the same everywhere.
  • 2) ... and those limits shoudn't be hardcoded, I suppose.

Changed 12 years ago by contyk

A picture stands for a thousand of words.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!