Opened 10 years ago

Closed 9 years ago

#9692 closed patch (fixed)

Pidgin sends IRC ISON messages > 512 bytes

Reported by: jchonig Owned by: elb
Milestone: 2.7.10 Component: IRC
Version: 2.7.9 Keywords: irc offline ison
Cc:

Description

If all the nicks in your buddy list add up to more than 512 bytes, Pidgin will happily send the longer message. The server will truncate the message and some of your buddies won't appear to be online.

This fix splits the ISON command before it reaches 512 bytes (510 accounting for CRLF).

It also counts the number of outstanding ISON messages instead of just TRUE/FALSE. The fact that irc_ison_one could cause ison_outstanding was probably a bug too.

Thanks.

Jeff

Attachments (4)

diff (6.1 KB) - added by jchonig 10 years ago.
Third version of the patches
pidgin-irc-diff-2.6.2 (6.1 KB) - added by jchonig 10 years ago.
Patch ported to 2.6.2
pidgin-irc-diff-2.6.4 (5.4 KB) - added by jchonig 10 years ago.
pidgin-ison-diff-2.7.9 (5.4 KB) - added by jchonig 9 years ago.
Diff update for 2.7.9 (just line offsets)

Download all attachments as: .zip

Change History (20)

comment:1 Changed 10 years ago by rekkanoryo

  • Milestone set to Patches Needing Review
  • Type changed from defect to patch

comment:2 Changed 10 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

I apologize for this patch going untouched for so long. Ideally, we would not use the preprocessor in this patch and instead use an enum. Ethan may have different ideas, however, and as he's the IRC maintainer, he has the final say.

Ethan, please take a look at this.

Changed 10 years ago by jchonig

Third version of the patches

comment:3 Changed 10 years ago by jchonig

  • Milestone changed from Patches Needing Improvement to Patches Needing Review

That is an old version of the patch, please review this version. I have been running it for three months w/o detecting any problems.

Thanks.

Jeff

comment:4 Changed 10 years ago by jchonig

Note that patch is still against 2.5.8, looking at 2.6.2 now.

Thanks.

Jeff

Changed 10 years ago by jchonig

Patch ported to 2.6.2

comment:5 Changed 10 years ago by jchonig

  • Version changed from 2.5.8 to 2.6.2

Attached a 2.6.2 version of this patch and am running it now. I'll report any issues with it.

Thanks.

Jeff

Changed 10 years ago by jchonig

comment:6 Changed 10 years ago by jchonig

  • Keywords ison added
  • Version changed from 2.6.2 to 2.6.4

Adding 2.6.4 patch (same as 2.6.2, but 2.6.2 was reversed) and bumping.

comment:7 Changed 9 years ago by jchonig

Bump!

comment:8 Changed 9 years ago by jchonig

  • Version changed from 2.6.4 to 2.7.0

2.6.4 patch applies cleanly to 2.7.0. Works fine too. Please review!

comment:9 Changed 9 years ago by Robby

  • Milestone changed from Patches Needing Review to 2.7.1

comment:10 Changed 9 years ago by rekkanoryo

  • Milestone changed from 2.7.1 to Patches Needing Review

Robby, in general the version milestones shouldn't be used for patches. This is still awaiting a detailed review from Ethan.

comment:11 Changed 9 years ago by elb

Certainly they shouldn't be used for releases which are already frozen when the patch has not been applied. ;-)

I'll try to make sure this does make it into 2.7.2. I apologize for letting it rot for so long. It's subtle enough that I feel it deserves my full attention, and I keep putting it off. John, hold me to it.

comment:12 Changed 9 years ago by jchonig

Ethan,

POKE (with a *STIFF* finger).

Patches apply fine to 2.7.3.

Thanks.

Jeff

comment:13 Changed 9 years ago by jchonig

  • Version changed from 2.7.0 to 2.7.7

POKE

Patch applies and works on 2.7.4, 2.7.5, 2.7.6 AND 2.7.7.

POKE

POKE

POKE

comment:14 Changed 9 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.7.10

I may just commit this without further review given how long this has been sitting here.

Changed 9 years ago by jchonig

Diff update for 2.7.9 (just line offsets)

comment:15 Changed 9 years ago by jchonig

  • Version changed from 2.7.7 to 2.7.9

I just applied this patch to 2.7.9. It was offset a few lines to I attached a new version of the patch.

I use IRC heavily at work (internal IRC servers) and this patch has so far not caused any noticeable problems.

Thanks.

Jeff

comment:16 Changed 9 years ago by jch@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 3851a1cf3c16073e17c31b6b23194cb26ce1be6f):
Prevent sending ISON messages larger than 512 bytes. Fixes #9692.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!