Opened 10 years ago

Closed 9 years ago

#9890 closed patch (fixed)

"View web profile" should link to http://people.icq.com/UIN for ICQ

Reported by: Selius Owned by: MarkDoliner
Milestone: 2.7.0 Component: ICQ
Version: 2.6.1 Keywords: icq web proflie link
Cc:

Description

I think, it would be better, if "View web profile" in "Get AIM Info" will link to http://people.icq.com/UIN for ICQ, not to http://profiles.aim.com/UIN as now.

It seems, that this URL is hardcoded at 3281 line of libpurple/protocols/oscar/oscar.c:

	tmp = g_strdup_printf("<a href=\"http://profiles.aim.com/%s\">%s</a>",
			purple_normalize(account, userinfo->sn), _("View web profile"));

, but I don't know whether it would be correct to just change this string.

Attachments (1)

view_web_profile_icq.patch (630 bytes) - added by Selius 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Selius

comment:1 Changed 9 years ago by Selius

  • Type changed from enhancement to patch
  • Version changed from 2.5.8 to 2.6.1

I attached a patch. It uses correct "View web profile" link address, both for ICQ and AIM. Sorry, patch is for old (2.6.1) version, as I didn't get source from repository. But it's only 2 lines long, so it shouldn't be a problem to apply it.

comment:2 Changed 9 years ago by darkrain42

  • Milestone set to Patches Needing Review

That looks right to me.

comment:3 follow-up: Changed 9 years ago by MarkDoliner

I see the ICQ website linking to http://www.icq.com/people/UIN/ Is there any reason we wouldn't use that URL?

comment:4 in reply to: ↑ 3 Changed 9 years ago by Selius

Replying to MarkDoliner:

I see the ICQ website linking to http://www.icq.com/people/UIN/ Is there any reason we wouldn't use that URL?

These URLs lead to the same page, so yes, we can use http://www.icq.com/people/UIN/

comment:5 follow-up: Changed 9 years ago by darkrain42

Selius, what name should you be credited for with this patch?

comment:6 Changed 9 years ago by darkrain42@…

(In ae36b4083bc8f72f21e331acfb95192e282f1e8f):
* Plucked 0e263caa5d687101e436029f2f8d09053ae06e23 (ivan.komarov@…): \"View Web Profile\" link now leads to the correct link for ICQ accounts (Refs #9890).

comment:7 in reply to: ↑ 5 Changed 9 years ago by Selius

Replying to darkrain42:

Selius, what name should you be credited for with this patch?

My name is Alexander Nartov. E-mail (if you need it): alexander.nartov@…

comment:8 Changed 9 years ago by darkrain42@…

  • Milestone changed from Patches Needing Review to 2.7.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 4c55071e378925a58e465c74df8ecfc872917260):
Changelog the View Web Profile fix. Closes #9890.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!