Changes between Version 3 and Version 4 of AliasFunctionReview

Timestamp:

Oct 31, 2008, 6:11:17 PM (15 years ago)

Author:

rlaager

Comment:

--

AliasFunctionReview

@@ -1 +1 @@
 Currently, libpurple has a number of functions (in blist.h) that take a !PurpleBuddy and return some string based on one or more aliases. Some differ only slightly. Is it necessary to have all of these functions?
 
-This came up because we almost certainly need to add some function to return !PurpleBuddy::alias only. The names we were picking clashed with the existing functions. Sadrul proposed _get_local_buddy_alias(). Richard agrees and suggests renaming that to _get_local_alias() in 3.0.0, replacing the currently unused (and newly deprecated) existing _get_local_alias().
+This came up because we almost certainly need to add some function to return PurpleBuddy::alias only. The names we were picking clashed with the existing functions. Sadrul proposed _get_local_buddy_alias(). Richard agrees and suggests renaming that to _get_local_alias() in 3.0.0, replacing the currently unused (and newly deprecated) existing _get_local_alias().
 
 (COALESCE is borrowed from SQL to mean "return the first non-NULL item".)
@@ -85 +85 @@
 _get_local_alias = COALESCE(alias, parent->alias, name);
         Unused, so deprecated just now on im.pidgin.pidgin.next.minor for 2.6.0.
-        Richard proposes that, for 3.0.0, this return !PurpleBuddy::alias.
+        Richard proposes that, for 3.0.0, this return PurpleBuddy::alias.
 
 _get_alias = COALESCE(alias, server_alias, parent->alias, name);