Changes between Version 1 and Version 2 of GSoC2009/HidingGobject/review071009

Timestamp:

Jul 16, 2009, 1:21:10 AM (15 years ago)

Author:

aluink

Comment:

--

GSoC2009/HidingGobject/review071009

@@ -1 +1 @@
 old rev: 811d6e22fc676b5d2f87ff0d8fff750662e4bc7b
+
 new rev: 2ef380ad3a75f214245ca5e1a34e7fc3d4e23914
 
@@ -40 +41 @@
 libpurple/group.h
  * doxygen comments are incorrect
-
-finch/gntblist.c
- * the comment starting on lines 238-239 can be deleted
- * line 1395 should be using PURPLE_BUDDY(node) and not typecasting directly
-   (glib will actually check the instance for us if we use the macro)
- * line 1398 should be using PURPLE_GROUP(node) and not typecasting directly
- * line 1676 nuke the comment and it's contents
- * line 2387:2388 use PURPLE_CHAT(n[12]) (see above)
- * line 2390:2391 use PURPLE_BUDDY(n[12]) (see above)
- * line 2393:2394 use PURPLE_CONTACT(n[12]) (see above)
- * line 2424:2425 use PURPLE_BUDDY(n[12]) (see above)
- * line 2467:2468 use PURPLE_BUDDY(n[12]) (see above)
-
-finch/plugins/grouping.c
- * line 36 needs to be a subclass or a group instances with the names "online"
-   and "offline".
-   (out of scope)
- * line 54 should be using PURPLE_CONTACT(node) (see above)
- * line 59 use PURPLE_BUDDY(node) (see above)
- * line 67 use PURPLE_CHAT(node) (see above)
- * line 110 online and offline haven't been initialized yet
- * line 115 online hasn't been initialized yet
- * line 137 needs to be a subclass, or a group instance with the name "meebo"
-   (out of scope)
- * line 269 looks like creating a group node instead _should_ be ok.
-   (out of scope)
- * line 288 should be ok for now, but should be using PURPLE_IS_BLIST_NODE
-   (out of scope)
 
 libpurple/blist-node.c
@@ -141 +114 @@
  * line 1197 uber line syndrome
  * line 1199 uber line syndrome
-
-pidgin/gtkblist.c (out of scope)
- * line 1513 uber line syndrome
- * line 1519 uber line syndrome
- * line 1554 uber line syndrome
- * line 1582 uber line syndrome
- * line 1639 uber line syndrome
- * line 2010 uber line syndrome
- * line 2356 uber line syndrome
- * lines 2665:2666 uber line syndromes
- * line 2776 uber line syndrome
- * line 3820 uber line syndrome
- * line 3822 uber line syndrome
- * line 3830 uber line syndrome
- * line 3860 uber line syndrome
- * line 4056 uber line syndrome
- * grown tired of recording these...  especially since they're out of scope